Clarify applying custom Puppet config #3752
Open
+37
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Needs tech review
|
The PR preview for dcb1f70 is available at theforeman-foreman-documentation-preview-pr-3752.surge.sh The following output files are affected by this PR: |
maximiliankolb
added
style review done
|
Turns out that hiding the sections completely is not what we want. Instead, I'll try to clarify the support level of applying custom configuration and generally clean up both sections a little bit. |
aneta-petrova
changed the title
maximiliankolb
approved these changes
Apr 4, 2025
Co-authored-by: Maximilian Kolb <[email protected]>
Absolutely! I haven't asked for one but will do so (hopefully) next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Excluding appendices on applying custom configuration from SatelliteWhy are you introducing these changes? (Explanation, links to references, issues, etc.)
The support level is not entirely clear right now.
This custom configuration is not supported for Satellite.Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
N/A
Checklists
Please cherry-pick my commits into: