-
Notifications
You must be signed in to change notification settings - Fork 97
Modify production environment backup recommendation #3747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Modify production environment backup recommendation #3747
Conversation
The PR preview for ad0f091 is available at theforeman-foreman-documentation-preview-pr-3747.surge.sh The following output files are affected by this PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style-wise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 4 reads "Perform an online backup only for debugging purposes." -- this should also be gone.
I would also re-word the "risks associated" paragraph, but don't have a good suggestion right now.
Just a suggestion to reword the "risks associated" paragraph: When you perform an online backup, the procedure repeats the Pulp database backup until no processes are altering the database. |
Thanks Brian! This definitely reads easier than the previous version. So how about this:
|
Looks good, Evgeni. The only suggestion I would make is to change the last sentence to: |
Since online backups are supported for production, after snapshot backups were dropped [1], removing the now irrelevant line about online backups being unsupported. [1] https://issues.redhat.com/browse/SAT-25667 JIRA: https://issues.redhat.com/browse/SAT-29507
1333291
to
ad0f091
Compare
Thanks @bangelic ! I have edited the para as per your and Evgeni's recommendation. However, I have kept the last line as per Evgeni's suggestion and tweaked the |
Since online backups are supported for production, after snapshot backups were dropped [1], removing the now irrelevant line about online backups being unsupported. [1] https://issues.redhat.com/browse/SAT-25667
JIRA: https://issues.redhat.com/browse/SAT-29507
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: