-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a new guide for provisioning virtual machines (2 of 3) #3608
base: master
Are you sure you want to change the base?
Create a new guide for provisioning virtual machines (2 of 3) #3608
Conversation
<productnumber>{ProjectVersion}</productnumber> | ||
<abstract> | ||
<para> | ||
TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: TODO
"Overture is composed last."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort Lena! Diff looks very reasonable to me but tech ACK is appreciated.
guides/common/modules/con_provisioning-virtual-machines-on-kubevirt.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/snip_warning-destroy-vm-on-host-delete.adoc
Outdated
Show resolved
Hide resolved
|
||
= {ProvisioningVirtualDocTitle} | ||
|
||
// This guide is not ready for stable releases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Do you have reasons to believe that the guide would not work for unstable and/or foreman-el/foreman-deb?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably should work for all builds, since images are not part of Katello. However, right now I'm not sure it works at all and I would prefer to revisit this question later :))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote for making this guide "working" for all stable releases. I'll keep it in mind during the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stejskalleos I've got some questions.
ifndef::provisioning-virtual[] | ||
include::modules/proc_configuring-the-security-token-validity-duration.adoc[leveloffset=+1] | ||
endif::[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stejskalleos The security token is not relevant for image-based provisioning, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is.
The machine will still ask Foreman to generate the Kickstart default template.
- Disabling tokens in the settings will remove the requirement though. To generate the template, you must ensure the host can be authenticated in Foreman. Usually, this is done by MAC / IP.
- If the image already contains generated kickstart, you don't have to call Foreman for the generated template; you don't need the token.
- Otherwise you need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stejskalleos What exactly are the networking requirements for image-based provisioning?
I thought that DHCP wasn't required, but the Prerequisites for image-based provisioning say that it is.
They still need at least one domain and one subnet, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly are the networking requirements
That's the thing, there are no exact requirements.
I'll describe it as best I can.
DHCP is always required. The host must have an IP address valid for its subnet and communication in the subnet.
Now, in Foreman, we have the terms managed and unmanaged DHCP, which, as far as I know, we came up with, rather than being an official tech buzzword.
-
Managed DHCP—Smart Proxy can add/update/remove DHCP records and leases and point the host to the bootloader file and boot configuration files. From the config files, it will get the path to the kernel and the init ramdisk and load them.
-
Unmanaged DHCP - Smart Proxy cannot do the stuff above, but that doesn't mean the host cannot obtain an IP from the DHCP.
In one sentence: The difference is whether or not the IP was assigned to the host by our smart-proxy, but the DHCP is still there.
So I would say that managed DHCP is preferred, but it is not required.
@stejskalleos Please, answer the questions above and check the TOC of the guide. |
What's TOC? |
|
||
= {ProvisioningVirtualDocTitle} | ||
|
||
// This guide is not ready for stable releases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote for making this guide "working" for all stable releases. I'll keep it in mind during the review
@@ -13,8 +13,12 @@ A default installation of {ProjectName} contains three predefined profiles: | |||
|
|||
You can apply compute profiles to all supported compute resources: | |||
|
|||
ifdef::provisioning,provisioning-cloud[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these flags used during the documentation generation?
What's the reasoning for not including these blocks in the end docs?
@@ -27,6 +27,4 @@ include::snip_prerequisites-common-compute-resource.adoc[] | |||
Ensure that no other DHCP services run on this network to avoid conflicts with {SmartProxyServer}. | |||
For more information about network service configuration for {SmartProxyServers}, see {ProvisioningDocURL}preparing-networking[Preparing networking] in _{ProvisioningDocTitle}_. | |||
|
|||
.Additional resources | |||
* For a list of permissions a non-admin user requires to provision hosts, see xref:permissions-required-to-provision-hosts_provisioning[]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to myself: snip_prerequisites-common-compute-resource.adoc
Table of contents :) |
What changes are you introducing?
Splitting Provisioning hosts into 3 new guides:
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
To mitigate pain points identified in SAT-26089 comments (public).
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Reviewers, please, focus on the title and heading structure in this PR. Using preview first is highly recommended.
Checklists
Please cherry-pick my commits into: N/A