Added Pacemaker module. #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Pacemaker module is one approach to allowing a long running script to pace itself according to API rate limits. It's a bit coarse and after using it some, there doesn't seem to be much advantage to pacing the final few calls across the remaining minutes of the hour vs. just one big sleep at the end, but I still wanted to keep the experiment. To properly decide if pacing the calls throughout the hour is worthwhile, the total number of calls would need to be fed to the calculation. Pacing all the time is a waste if there will be less calls in the hour than the limit remaining. In addition, if there will be more calls than the limit remaining, then choosing to pace versus one long wait once the limit is exhausted results in the same amount of time waiting, so there seems to be little advantage to pacing at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[submitting a pull request for your review, but prolly don't think
this is worthwhile as-is].
The Pacemaker module is one approach to allowing a long running script
to pace itself according to API rate limits. It's a bit coarse and after
using it some, there doesn't seem to be much advantage to pacing the
final few calls across the remaining minutes of the hour vs. just one
big sleep at the end, but I still wanted to keep the experiment.
To properly decide if pacing the calls throughout the hour is
worthwhile, the total number of calls would need to be fed to the
calculation. Pacing all the time is a waste if there will be less calls
in the hour than the limit remaining.
In addition, if there will be more calls than the limit remaining, then
choosing to pace versus one long wait once the limit is exhausted
results in the same amount of time waiting, so there seems to be little
advantage to pacing at all.