Lifting Refactor #555
Merged
Lifting Refactor #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plt-amy
reviewed
Aug 22, 2025
plt-amy
reviewed
Aug 22, 2025
Member
|
i get the feeling that im the only person involved with this project that actually doesn't like typeclasses because every other pr i have to keep parrying people that are like "lets just do mathlib again" |
plt-amy
reviewed
Aug 22, 2025
plt-amy
force-pushed
the
lifting-refactor
branch
from
0929f19 to
c9dc5e3
Compare
Member
New pages
Changed pages
|
ncfavier
reviewed
Aug 24, 2025
plt-amy
reviewed
Aug 28, 2025
TOTBWF
force-pushed
the
lifting-refactor
branch
from
7c4b3c7 to
d3d75cf
Compare
ncfavier
reviewed
Aug 28, 2025
plt-amy
reviewed
Aug 28, 2025
ncfavier
reviewed
Aug 28, 2025
TOTBWF
force-pushed
the
lifting-refactor
branch
from
5220e3e to
c5abcd8
Compare
ncfavier
previously approved these changes
Aug 29, 2025
plt-amy
reviewed
Sep 1, 2025
Co-authored-by: Amélia <[email protected]>
Co-authored-by: Amélia <[email protected]>
This makes the inteface to Arrows more consistent, so you don't have `StrongEpis C` but just a bare `Monos`
Suggested-by: Amélia <[email protected]>
Co-authored-by: Naïm Camille Favier <[email protected]>
We use ∘-is-epic and ∘-is-monic, so these names should align. I've also removed the explicit arguments to align with the non-strong versions of these lemmas.
Suggested-by: Naïm Camille Favier <[email protected]>
Suggested-by: Naïm Camille Favier <[email protected]>
Suggested-by: Naïm Camille Favier <[email protected]>
plt-amy
force-pushed
the
lifting-refactor
branch
from
7434ddb to
c219b8c
Compare
plt-amy
approved these changes
Sep 1, 2025
4e554c4c
pushed a commit
to 4e554c4c/1lab
that referenced
this pull request
Nov 26, 2025
This PR refactors the APIs for lifting and orthogonality properties, and also redefines projective/injective objects in terms of lifts. I've also made some minor code improvements along the way, like pulling out `Factorisation` into its own module. Closes the1lab#552. --------- Co-authored-by: Amélia <[email protected]> Co-authored-by: Naïm Camille Favier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the APIs for lifting and orthogonality properties, and also redefines projective/injective objects in
terms of lifts. I've also made some minor code improvements along the way, like pulling out
Factorisationinto its own module. Closes #552.