Add support for Mission Control and Launchpad keycodes #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit only adds support in the "Configure" section, so they still won't be recognized by the "Macros" section. To do so would require amending the auto-complete-able keycodes, but I'm not sure there's any incentive to do so given what these two functions do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Recently got an Apple-compatible keyset and I realised via didn't offer support for two macOS specific keycodes:
KC_MCTLandKC_LPAD(respectively onF3andF4on Apple keyboards and laptops), so I made them available to the Configurator.So far it Works On My Machine™, but I'm new to this so maybe some other files should be modified as well? You tell me and I'll gladly do it.
This commit only adds support in the "Configure" section, so they still won't be recognized by the "Macros" section. To do so would require amending the auto-complete-able keycodes, but I'm not sure there's any incentive to do so given what these two keys do.