dvt: remove nounset bash opt
#64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`writeShellApplication` has `[ "errexit" "nounset" "pipefail" ]`
set for its `bashOptions` parameter. This sets these at the top
of every generated script.
The error message `"no template specified"` is never printed since
the script immediately dies because `${1}` isn't set and `nounset`
is enabled. Excluding the option from the script generation allows
the error message to print rather than just
`result/bin/dvt: line 6: 1: unbound variable` which isn't helpful.
|
@lucperkins Whenever you get time. Thanks 😀👍. |
lucperkins
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
writeShellApplicationhas[ "errexit" "nounset" "pipefail" ]set for its
bashOptionsparameter. This sets these at the topof every generated script.
The error message
"no template specified"is never printed sincethe script immediately dies because
${1}isn't set andnounsetis enabled. Excluding the option from the script generation allows
the error message to print rather than just
result/bin/dvt: line 6: 1: unbound variablewhich isn't helpful.https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/trivial-builders/default.nix#L261