Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to alex@11 #25

Merged
merged 9 commits into from
Nov 8, 2023
Merged

Update to alex@11 #25

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c298a25
bump alex
tyler36 Nov 7, 2023
7504ef0
use dynamic imports
tyler36 Nov 7, 2023
57dee7a
workflow uses supported node versions
tyler36 Nov 8, 2023
fcf14d4
update alex version
tyler36 Nov 8, 2023
9e1d828
add textlint-scripts
tyler36 Nov 8, 2023
e27b519
add textlint-scripts to workflow
tyler36 Nov 8, 2023
335b517
Update .github/workflows/test.yml
tyler36 Nov 8, 2023
9f7a8f7
Update `yarn.lock`
tyler36 Nov 8, 2023
4a4e571
fix: use resolution
azu Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"textlint-scripts": "^12.1.1"
},
"dependencies": {
"alex": "^9.1.1",
"alex": "^11",
"textlint-rule-helper": "^2.3.0"
}
}
8 changes: 5 additions & 3 deletions src/textlint-rule-alex.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// LICENSE : MIT
"use strict";
import {RuleHelper} from "textlint-rule-helper";
import alex from "alex";

const defaultOptions = {
allow: undefined,
deny: undefined,
Expand Down Expand Up @@ -33,7 +33,9 @@ export default function textlintRuleAlex(context, options = {}) {
report(node, ruleError);
};
return {
[Syntax.Str](node){
async [Syntax.Str](node){
const alex = await import("alex").then(mod => mod.markdown); // markdown equals to default export https://github.com/get-alex/alex/blob/1b4c1be7991b30502cd56fb1d4769708df6853a5/index.js#L56

if (helper.isChildNode(node, [Syntax.Link, Syntax.Image, Syntax.BlockQuote, Syntax.Emphasis])) {
return;
}
Expand All @@ -44,4 +46,4 @@ export default function textlintRuleAlex(context, options = {}) {
});
}
}
}
}
Loading