Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reactStrictMode as an option to render #1390

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

bernardobelchior
Copy link
Contributor

@bernardobelchior bernardobelchior commented Apr 2, 2025

What:

Add an ability to override the global reactStrictMode configuration on a per-test basis.

Why:

At MUI, our tests use a small wrapper around React Testing Library and had this functionality. However, it was broken in the upgrade to React 19 since StrictMode won't double call effects on initial mount unless StrictMode is rendered at the root of the tree. Since we were rendering React.StrictMode inside the component passed to the wrapper property, effects aren't being called twice in React 19.

How:

Added a reactStrictMode to renderOptions.

Checklist:

Sorry, something went wrong.

Copy link

codesandbox-ci bot commented Apr 2, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5be1d35:

Sandbox Source
react-testing-library-examples Configuration

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flawless. Thank you! Will merge once docs are settled.

@eps1lon eps1lon merged commit 8782f3b into testing-library:main Apr 2, 2025
10 checks passed
@eps1lon
Copy link
Member

eps1lon commented Apr 2, 2025

@all-contributors add @bernardobelchior for code, docs

Copy link
Contributor

@eps1lon

I've put up a pull request to add @bernardobelchior! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants