-
Notifications
You must be signed in to change notification settings - Fork 150
fix(no-node-access): Improve detection logic in no-node-access to resolve imported aliases and setup instances #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
y-hsgw
wants to merge
9
commits into
testing-library:main
Choose a base branch
from
y-hsgw:pr/fix-no-node-access
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+697
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1033 +/- ##
==========================================
- Coverage 96.30% 96.14% -0.16%
==========================================
Files 47 49 +2
Lines 2542 2675 +133
Branches 1051 1110 +59
==========================================
+ Hits 2448 2572 +124
- Misses 94 102 +8
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…NodeChain function
@y-hsgw thanks! I'll try to review this during the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in this comment, I’ve implemented a resolveToTestingLibraryFn utility inspired by eslint-plugin-jest’s parseJestFnCall.
Checks
Changes
resolveToTestingLibraryFn
, which improves accuracy by accepting aCallExpression
node and resolving where it comes into the file — in other words, tracing it back to its original import source. This follows the same principle used in eslint-plugin-jest's parseJestFnCall.no-node-access
rule output false-positive warning after 7.5.0 release #1024:userEvent.setup()
instances with custom variable names (not just user) are now recognized and excluded from being flagged incorrectly (e.g.,const userEvt = userEvent.setup();
userEvt.click(...)
is no longer a false positive).I understand this PR is a bit large—if it would help with the review process, I'm happy to split it into smaller parts. Please let me know if you'd prefer that.🙇♂️
Context
Fixes #1024