Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getQueriesForElement types #1354

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rodgobbi
Copy link

@rodgobbi rodgobbi commented Mar 31, 2025

What:

Fix getQueriesForElement type.

Why:

Type definition for getQueriesForElement doesn't match the JS implementation.

How:

Add initialValue third parameter to the function signature.

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests
  • TypeScript definitions updated
  • Ready to be merged

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me.
The failing build is something we'll have to look into, I will create an issue to look into this.

@rodgobbi
Copy link
Author

rodgobbi commented Apr 3, 2025

This change looks good to me. The failing build is something we'll have to look into, I will create an issue to look into this.

Thanks for checking @timdeschryver 👍

I noticed the CI failing and checked if it happened to other PRs and indeed it looked like some issue in every PR.

Lemme know when it gets fixed, I can merge with the main branch and push to fix if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants