Pull retry policy for pulling remote images#7047
Open
jccampanero wants to merge 13 commits intotestcontainers:mainfrom
Open
Pull retry policy for pulling remote images#7047jccampanero wants to merge 13 commits intotestcontainers:mainfrom
jccampanero wants to merge 13 commits intotestcontainers:mainfrom
Conversation
Fix number of attempts comparison expression.
…y' into 6675_3829_image_pull_retry_policy
# Conflicts: # core/src/main/java/org/testcontainers/images/RemoteDockerImage.java
Contributor
linghengqian
left a comment
linghengqian
left a comment
There was a problem hiding this comment.
Wasn't this fixed via #9417 ?
In a similar way as defined in testcontainers#9417.
Author
|
I apologize for the late reply @linghengqian. i think that the solution provided by Edu in #9417 addresses the problem by providing a configurable timeout for retry, and fixing #6675. But the scope of the PR tries to be more ambitious by defining a configurable policy framework to deal with retries; for instance, it would allow use cases such as the one stated in #3829. I will try to resolve the conflicts in Do you think we can work on it in order to include the proposed solution in the project? Thank you very much for your support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull request try proposing the definition of the concept of image pull retry policy if an error occurs when pulling remote images.
Try to address #3829 and #6675, allowing both the definition of custom retry policies when dealing with a remote image pull error and provides different retry policies with custom timeouts, number of attempts, etc.
It is a work in progress, test cases should be added: please, consider it a starting point for discussing the proposal.