chore: Update Toxiproxy NuGet dependency to a .NET compatible version #1568
Conversation
HofmeisterAn
added
the
chore
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary by CodeRabbit
WalkthroughUpdates include bumping the .NET devcontainer feature, replacing the Toxiproxy NuGet package, converting synchronous Toxiproxy test calls to async, removing BOM characters from Mosquitto files, and a small Playwright docs example tweak. Changes
Sequence Diagram(s)sequenceDiagram
participant Test as Test (ToxiproxyContainerTest)
participant Client as ToxiproxyClient
participant Proxy as ProxyContainer
Note over Test,Client: Async proxy creation flow (updated)
Test->>Client: AddAsync(proxy)
activate Client
Client-->>Test: Task<Proxy> (completed)
deactivate Client
Note over Test,Proxy: Async toxic application (updated)
Test->>Proxy: AddAsync(latencyToxic)
activate Proxy
Proxy-->>Test: Task<Toxic> (completed)
deactivate Proxy
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (12)
.devcontainer/devcontainer.json(1 hunks)Directory.Packages.props(1 hunks)Testcontainers.dic(1 hunks)Testcontainers.sln.DotSettings(1 hunks)docs/modules/playwright.md(1 hunks)src/Testcontainers.Mosquitto/MosquittoBuilder.cs(1 hunks)src/Testcontainers.Mosquitto/MosquittoConfiguration.cs(1 hunks)src/Testcontainers.Mosquitto/MosquittoContainer.cs(1 hunks)src/Testcontainers.Mosquitto/Testcontainers.Mosquitto.csproj(1 hunks)tests/Testcontainers.Mosquitto.Tests/Testcontainers.Mosquitto.Tests.csproj(1 hunks)tests/Testcontainers.Toxiproxy.Tests/Testcontainers.Toxiproxy.Tests.csproj(1 hunks)tests/Testcontainers.Toxiproxy.Tests/ToxiproxyContainerTest.cs(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-08T09:04:00.045Z
Learnt from: HofmeisterAn
Repo: testcontainers/testcontainers-dotnet PR: 1509
File: tests/Testcontainers.Grafana.Tests/GrafanaContainerTest.cs:45-46
Timestamp: 2025-11-08T09:04:00.045Z
Learning: In xUnit.net test methods in the testcontainers-dotnet project, ConfigureAwait(true) is recommended and correct to use, as it ensures proper synchronization context capture for xUnit's test parallelism management. Do not suggest changing ConfigureAwait(true) to ConfigureAwait(false) in test methods.
Applied to files:
tests/Testcontainers.Toxiproxy.Tests/ToxiproxyContainerTest.cs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: ci (Testcontainers.ActiveMq, ubuntu-24.04)
- GitHub Check: ci (Testcontainers.ArangoDb, ubuntu-24.04)
- GitHub Check: ci (Testcontainers.BigQuery, ubuntu-24.04)
- GitHub Check: ci (Testcontainers.Azurite, ubuntu-24.04)
- GitHub Check: ci (Testcontainers.Bigtable, ubuntu-24.04)
- GitHub Check: ci (Testcontainers.Cassandra, ubuntu-24.04)
- GitHub Check: analyze (csharp)
🔇 Additional comments (11)
Testcontainers.dic (1)
38-38: LGTM!The addition of "toxiproxy" to the dictionary is consistent with the package update from Toxiproxy.Net to ToxiproxyNetCore.
tests/Testcontainers.Mosquitto.Tests/Testcontainers.Mosquitto.Tests.csproj (1)
1-1: LGTM!The BOM removal improves file encoding consistency and is part of the broader cleanup mentioned in the PR objectives.
Testcontainers.sln.DotSettings (1)
47-47: LGTM!The dictionary entry addition is consistent with the Toxiproxy package changes and prevents IDE spell-check warnings.
tests/Testcontainers.Toxiproxy.Tests/ToxiproxyContainerTest.cs (2)
77-78: LGTM!The conversion to async is correct and aligns with the ToxiproxyNetCore package API. The use of
ConfigureAwait(true)is appropriate for xUnit test methods.
110-111: LGTM!The async conversion is correct and consistent with the proxy addition pattern above.
src/Testcontainers.Mosquitto/MosquittoContainer.cs (1)
1-1: LGTM!The BOM removal is part of the encoding cleanup mentioned in the PR objectives and improves file consistency.
src/Testcontainers.Mosquitto/Testcontainers.Mosquitto.csproj (1)
1-1: LGTM!The BOM removal completes the encoding cleanup for the Mosquitto module files.
.devcontainer/devcontainer.json (1)
16-19: Version 2.4.0 verified as the latest stable release.The .NET devcontainer feature version 2.4.0 is the latest stable version, so the update is current and appropriate. No action required.
src/Testcontainers.Mosquitto/MosquittoConfiguration.cs (1)
1-1: LGTM! BOM character removed.The removal of the byte order mark improves file encoding consistency with no functional impact.
src/Testcontainers.Mosquitto/MosquittoBuilder.cs (1)
1-1: LGTM! BOM character removed.Consistent encoding cleanup across the Mosquitto module.
Directory.Packages.props (1)
91-91: Package replacement aligns with .NET compatibility goals.The centralized switch from
Toxiproxy.NettoToxiproxyNetCoresupports the PR's objective of using a .NET-compatible version. However, ensure that all consuming code has been updated to accommodate any API differences between these packages.This change depends on verification that test code has been properly updated (see comment on the test project file).
tests/Testcontainers.Toxiproxy.Tests/Testcontainers.Toxiproxy.Tests.csproj
Show resolved
Hide resolved
What does this PR do?
This PR fixes a few minor issues that came up after merging other PRs and tidies up some small inconsistencies that slipped through.
Why is it important?
-
Related issues
-