Skip to content

v1.0.1 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 28, 2019
Merged

v1.0.1 #23

merged 10 commits into from
Jan 28, 2019

Conversation

UlisesGascon
Copy link
Collaborator

@UlisesGascon UlisesGascon commented Jan 27, 2019 •
edited
Loading

Changelog

Documentation #21

@UlisesGascon UlisesGascon self-assigned this Jan 27, 2019
@UlisesGascon
Copy link
Collaborator Author

@terrierscript let me know what do you think about the changes... and if you agree let's merge it and publish the new release to NPM ;-)

terrierscript
terrierscript approved these changes Jan 27, 2019
View reviewed changes
Copy link
Owner

@terrierscript terrierscript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for update!

I want some signature use terrierscript and not want to use S. Suzuki
Please accept suggestion

terrierscript and others added 3 commits January 27, 2019 14:07
@terrierscript @UlisesGascon
Update package.json
0268ae0 
Co-Authored-By: UlisesGascon <[email protected]>
@terrierscript @UlisesGascon
Update LICENSE
11a51ec 
Co-Authored-By: UlisesGascon <[email protected]>
@terrierscript @UlisesGascon
Update README.md
cf1dffe 
Co-Authored-By: UlisesGascon <[email protected]>
@UlisesGascon
Copy link
Collaborator Author

UlisesGascon commented Jan 27, 2019 •
edited
Loading

Awesome! suggestions accepted 👍

can we merge now? :-)

@terrierscript terrierscript merged commit 53a84d6 into master Jan 28, 2019
@terrierscript
Copy link
Owner

I published it

@UlisesGascon
Copy link
Collaborator Author

Awesome! Thanks @terrierscript !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrierscript terrierscript terrierscript approved these changes

Assignees

@UlisesGascon UlisesGascon

Labels
📖 documentation 💪 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UlisesGascon @terrierscript