generated from terraform-ibm-modules/terraform-ibm-module-template
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: support for configuration #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shemau
wants to merge
14
commits into
main
Choose a base branch
from
configuration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run pipeline |
Nearing completion. One final pass and tidy up before being ready for review. |
The upgrade test, failed showing
Which is the new option being added and flagged update in place. |
This is definitely just showing an update in place. So I am going to skip upgrade test.
|
/run pipeline |
/run pipeline |
iamar7
reviewed
Feb 14, 2025
iamar7
reviewed
Feb 14, 2025
iamar7
reviewed
Feb 14, 2025
/run pipeline |
iamar7
reviewed
Feb 20, 2025
iamar7
reviewed
Feb 20, 2025
/run pipeline |
/run pipeline |
/run pipeline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#311
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Add support for passing a configuration block when creating the ICD instance. This includes base module, fscloud sub module and deployable architecture.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers