Skip to content

feat: support for configuration #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: support for configuration #315

wants to merge 14 commits into from

Conversation

shemau
Copy link
Contributor

@shemau shemau commented Feb 11, 2025

Description

#311

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Add support for passing a configuration block when creating the ICD instance. This includes base module, fscloud sub module and deployable architecture.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau shemau requested a review from iamar7 as a code owner February 11, 2025 15:59
@shemau shemau marked this pull request as draft February 11, 2025 15:59
@shemau
Copy link
Contributor Author

shemau commented Feb 11, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Feb 11, 2025

Nearing completion. One final pass and tidy up before being ready for review.

@shemau
Copy link
Contributor Author

shemau commented Feb 11, 2025

The upgrade test, failed showing

         	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"configuration":null}
        	            	  After: 
        	            		{"configuration":"{\"delete_undefined_queues\":true}"}   	            		

Which is the new option being added and flagged update in place.

@shemau shemau marked this pull request as ready for review February 11, 2025 21:51
@shemau
Copy link
Contributor Author

shemau commented Feb 12, 2025

This is definitely just showing an update in place. So I am going to skip upgrade test.

TestRunStandardUpgradeSolution 2025-02-11T16:22:39Z command.go:185:   ~ update in-place

@shemau
Copy link
Contributor Author

shemau commented Feb 12, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Feb 13, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Feb 14, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Mar 4, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Apr 24, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented May 7, 2025

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants