-
Notifications
You must be signed in to change notification settings - Fork 2
split observability DA consumption #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
Co-authored-by: Conall Ó Cofaigh <[email protected]>
…ules/terraform-ibm-event-notifications into split-observability-da
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will want addons tests to trigger - so we need to merge terraform-ibm-modules/common-dev-assets#1191 and bump the submodule in this Pr to have tests run
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should stop passing a value for existing_kms_instance_crn
in the addons tests now that KMS is not mandated in Observability
/run pipeline |
/run pipeline |
1 similar comment
/run pipeline |
…ules/terraform-ibm-event-notifications into split-observability-da
/run pipeline |
/run pipeline |
/run pipeline |
…ules/terraform-ibm-event-notifications into split-observability-da
/run pipeline |
Description
Remove virtual input workaroundRelease required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers