Skip to content

split observability DA consumption #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

rajatagarwal-ibm
Copy link
Member

@rajatagarwal-ibm rajatagarwal-ibm commented Jul 16, 2025

Description

  • Split Observability DA
  • Remove virtual input workaround

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

rajatagarwal-ibm and others added 3 commits July 17, 2025 13:12
Co-authored-by: Conall Ó Cofaigh <[email protected]>
…ules/terraform-ibm-event-notifications into split-observability-da
@ocofaigh
Copy link
Contributor

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will want addons tests to trigger - so we need to merge terraform-ibm-modules/common-dev-assets#1191 and bump the submodule in this Pr to have tests run

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should stop passing a value for existing_kms_instance_crn in the addons tests now that KMS is not mandated in Observability

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

ocofaigh
ocofaigh previously approved these changes Jul 17, 2025
@ocofaigh
Copy link
Contributor

/run pipeline

1 similar comment
@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants