fix: Adding UI validations for MiG and instance template #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrkk123
requested review from
ayushmjain,
erlanderlo,
q2w and
a team
as code owners
pawan1210
reviewed
Aug 18, 2025
pawan1210
reviewed
Aug 18, 2025
pawan1210
reviewed
Aug 19, 2025
| network: | ||
| name: network | ||
| title: Network | ||
| regexValidation: ^(?:projects\/[a-z0-9-]+\/)?global\/networks\/[a-z0-9-]{1,63}$ |
There was a problem hiding this comment.
I think just network name is also allowed here.
pawan1210
reviewed
Aug 19, 2025
| subnetwork: | ||
| name: subnetwork | ||
| title: Subnetwork | ||
| regexValidation: ^(?:projects\/[a-z0-9-]+\/)?(?:regions\/[a-z0-9-]+\/)?subnetworks\/[a-z0-9-]{1,63}$ |
pawan1210
reviewed
Aug 19, 2025
| name: network | ||
| title: Network | ||
| level: 1 | ||
| regexValidation: ^(?:projects\/[a-z0-9-]+\/)?global\/networks\/[a-z0-9-]{1,63}$ |
There was a problem hiding this comment.
Network name is not getting passed here.
pawan1210
reviewed
Aug 19, 2025
| name: subnetwork | ||
| title: Subnetwork | ||
| level: 1 | ||
| regexValidation: ^(?:projects\/[a-z0-9-]+\/)?(?:regions\/[a-z0-9-]+\/)?subnetworks\/[a-z0-9-]{1,63}$ |
There was a problem hiding this comment.
just name is not getting passed here.
pawan1210
reviewed
Aug 19, 2025
modules/mig/metadata.display.yaml
Outdated
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # http://www.apache.org/licenses/LICENSE-2.0 |
pawan1210
reviewed
Aug 25, 2025
| network: | ||
| name: network | ||
| title: Network | ||
| regexValidation: "^(?:[a-z0-9-]{1,63}|projects\\/[a-z0-9-]+\\/global\\/networks\\/[a-z0-9-]{1,63})$" |
There was a problem hiding this comment.
We don't need to add any escape characters.
pawan1210
reviewed
Aug 25, 2025
| subnetwork: | ||
| name: subnetwork | ||
| title: Subnetwork | ||
| regexValidation: "^(?:[a-z0-9-]{1,63}|(?:projects\\/[a-z0-9-]+\\/)?(?:regions\\/[a-z0-9-]+\\/)?subnetworks\\/[a-z0-9-]{1,63})$" |
pawan1210
reviewed
Aug 25, 2025
| network_ip: | ||
| name: network_ip | ||
| title: Network Ip | ||
| regexValidation: ^((25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)$ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.