feat: Support RDS Cluster monitoring interval and role arn #485
+43
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbabenko
requested changes
Feb 18, 2025
| variable "cluster_monitoring_interval" { | ||
| description = "Interval, in seconds, in seconds, between points when Enhanced Monitoring metrics are collected for the DB cluster. To turn off collecting Enhanced Monitoring metrics, specify 0. The default is 0. Valid Values: 0, 1, 5, 10, 15, 30, 60" | ||
| type = number | ||
| default = 0 |
There was a problem hiding this comment.
Suggested change
| default = 0 | |
| default = null |
There was a problem hiding this comment.
This is similar to what we're doing for var.monitoring_interval:
terraform-aws-rds-aurora/variables.tf
Lines 415 to 419 in 685b01b
That way we can use
var.cluster_monitoring_interval > 0 in places to determine if we should configure a monitoring role since it must be greater than 0 in that case. Or should we let var.create_monitoring_role handle that on its own? Let me know what you think.
Co-authored-by: Anton Babenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support enhanced monitoring at the cluster level.
Motivation and Context
Closes: #483
Breaking Changes
No.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request