Repository navigation
Fix LogLinarith flipping a > b into Theta(b) >= Theta(a) - #57
Open
chessing234 wants to merge 1 commit into
Open
chessing234 wants to merge 1 commit into
chessing234 wants to merge 1 commit into
Conversation
Contributor
Author
|
@teorth loglinarith still turns a > b into theta(b) >= theta(a). this has been sitting since mid september and still merges clean. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LogLinarithmappeda > btoTheta(b) >= Theta(a), so it could prove the false goala ≲ band fail on the true goala ≳ b.>=, matchingApplyTheta.Test plan
uv run --with pytest pytest tests/test_all.py::TestAll::test_loglinarith_gt_does_not_flip tests/test_all.py::TestAll::test_loglinarith_gt_proves_gtrsim