Repository navigation
Keep proof mode active when earlier or nested goals remain - #56
Open
chessing234 wants to merge 1 commit into
Open
chessing234 wants to merge 1 commit into
chessing234 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With three goals, solving the second and then the third can exit tactic mode while the first is still unresolved.
find_sorryforgets the earlier open goal when it crosses a completed sibling. It also loses the first open goal inside a nested subtree, andcount_sorriesomits nested goals after the current node.Preserve the first and last open goals when the target is outside a subtree, and keep the previous goal when a completed sibling has no replacement. Count all descendant goals after an internal target. A regression uses the real
ProofAssistant,SplitGoal, andSimpAllflow and verifies that tactic mode continues until the first goal is solved.Validation: five focused tests pass. The complete suite reports 28 passed and one failure; current upstream has the identical
test_linarith_failure_exampleZ3 symbolic-Boolean failure (23 passed, one failed). That existing counterexample issue is separate from navigation and is already covered by an open PR.git diff --checkpasses.