Repository navigation
Require symbolic evidence before promoting a variable to nonzero - #55
Open
chessing234 wants to merge 1 commit into
Open
chessing234 wants to merge 1 commit into
chessing234 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsNonzero("x")currently solvesNe(x, 0)for an arbitrary declared real variable with no hypothesis. Python'sx != 0is structural inequality and evaluates toTruebefore the proof checker sees it; this also permits promotion whenEq(x, 0)is a hypothesis.Pass SymPy's
Ne(x, 0)to the checker. Regression tests cover absent and contradictory evidence for real/rational/integer declarations, valid evidence through both tactic argument forms, substitution into an unsolved goal, and preservation of the input proof state.Validation:
PYTHONPATH=src python -m pytest tests -q: 26 passed; the existingtest_linarith_failure_examplefails identically on unchanged upstream (23 passed, 1 failed there). All 3 new regression tests pass; the original unsound proof reproduces on upstream.This defect was reproduced during a code audit; no existing issue report is claimed.