Repository navigation
Remove unused vulnerable packages and patch the UI toolchain - #54
Open
chessing234 wants to merge 1 commit into
Open
chessing234 wants to merge 1 commit into
chessing234 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UI installs the unrelated
biomepackage alongside the actual formatter,@biomejs/biome. The unused package pulls in obsolete request/form-data/lodash dependencies. The unused geist dependency also brings in an unnecessary Next.js dependency tree. Remove both, preserving the existing Biome formatter and UI fonts.Refresh the remaining lockfile to patched releases and upgrade Vitest to 5.0.0 to address its mock-server file-read advisory. Set Node >=22.12 and use Node 22 with npm ci in both CI and Pages builds so those workflows install the tested lockfile with a supported runtime.
Validation: npm ci, npm run build, npm run test -- --run (one test), and npm run lint:ci pass. npm audit reports zero vulnerabilities, down from 26 affected dependency entries (including 6 critical). Build warnings about the existing Pyodide Node-module externals and large bundle remain. This PR does not claim the unused Next.js server was exposed by the static application.
Advisory examples: form-data boundary generation, Vitest mock-server traversal, and Vite arbitrary file read.
Prepared with Codex assistance.