Skip to content
This repository was archived by the owner on Mar 17, 2023. It is now read-only.

Remove dnd.js in favour of plain ReasonML Bindings #82

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

rolandpeelen
Copy link
Contributor

📔 Description

Since none of our calls use JSX directly, but only transpiled direct function calls, the dnd.js file added a dependency on an extra transpilation step. Removing it in favour of these bindings removes that. Making for a better UX

📝 Checklist

  • All user-facing changes have changelog entries.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Check if the build runs through / run locally

Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing deps sounds good. No visible changes afaict.

@rolandpeelen rolandpeelen merged commit 6d355bc into master Aug 31, 2021
@rolandpeelen rolandpeelen deleted the topic/drag-n-drop-plain-js branch August 31, 2021 11:46
@dominiklohmann dominiklohmann added the enhancement An improvement of existing code label Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants