[NOT FOR MERGING] Core ML Delegate Tests on iOS Device #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priankakariat
commented
Jul 14, 2022
| @@ -88,6 +88,17 @@ StatusOr<ImageClassifierOptionsCpp> CreateImageClassifierCppOptionsFromCOptions( | |||
| cpp_options.set_score_threshold( | |||
| c_options->classification_options.score_threshold); | |||
|
|
|||
| cpp_options.mutable_base_options() | |||
There was a problem hiding this comment.
Hardcoding core ml delegate settings here since these changes are only for testing on a device.
There was a problem hiding this comment.
Once issues are fixed these can be implemented in the iOS framework.
priankakariat
commented
Jul 14, 2022
| @@ -24,6 +24,7 @@ objc_library( | |||
| "//tensorflow_lite_support/ios/task/processor:TFLClassificationResultHelpers", | |||
| "//tensorflow_lite_support/ios/task/vision/utils:GMLImageUtils", | |||
| "//tensorflow_lite_support/odml/ios/image:MLImage", | |||
| "@org_tensorflow//tensorflow/lite/experimental/acceleration/configuration:coreml_plugin", | |||
There was a problem hiding this comment.
I have linked in the cormel_plugin target here. I am still getting the following error:
"Could not create CoreML plugin. Have you linked in the CoreML_plugin target?"
This reverts commit d7ee00e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.