WIP: Run tensorflow-sys' test under valgrind #70
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…locator (`alloc_system`)
This insure that the pre-built library is downloaded, if required.
It does not make sense to test the idiomatic rust wrapper if the low-level (`-sys`) crate is failing.
This reverts commit 517034f. The command 'tree' is not available. See for example https://travis-ci.org/tensorflow/rust/jobs/211461348 on line 661: $ tree /home/travis/build.sh: line 62: tree: command not found The command "tree" exited with 127.
…ctly This should prevent valgrind detecting errors in cargo itself.
Example error: ==6638== 26 bytes in 1 blocks are possibly lost in loss record 13,446 of 55,786 ==6638== at 0x4C2B0E0: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==6638== by 0xA0BBF68: std::string::_Rep::_S_create(unsigned long, unsigned long, std::allocator<char> const&) (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.22) ==6638== by 0xA0BC086: ??? (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.22) ==6638== by 0xA0BDD35: std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, std::allocator<char> const&) (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.22) ==6638== by 0x80D734F: tensorflow::KernelDefBuilder::TypeConstraint(char const*, tensorflow::DataType) (in /home/travis/build/tensorflow/rust/tensorflow-sys/target/libtensorflow-cpu-linux-x86_64-1.0.0/lib/libtensorflow.so) ==6638== by 0x6953F2C: _GLOBAL__sub_I_batchtospace_op.cc (in /home/travis/build/tensorflow/rust/tensorflow-sys/target/libtensorflow-cpu-linux-x86_64-1.0.0/lib/libtensorflow.so) ==6638== by 0x4010109: call_init.part.0 (dl-init.c:78) ==6638== by 0x40101F2: call_init (dl-init.c:36) ==6638== by 0x40101F2: _dl_init (dl-init.c:126) ==6638== by 0x4001309: ??? (in /lib/x86_64-linux-gnu/ld-2.19.so) See https://travis-ci.org/tensorflow/rust/jobs/211495588#L759
Contributor
Author
|
Will work in own repo until this is ready as to not spam everybody. |
ramon-garcia
pushed a commit
to ramon-garcia/tensorflow-rust
that referenced
this pull request
May 20, 2023
* tensorflow#70 row-wise folding * tensorflow#70 row-wise folding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress for running
tensorflow-sys' tests under valgrind.This PR is not yet ready: it's hard to debug without opening a pull request.
Should close #69.