Moving runtime bindings into their own crate #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the runtime bindings live inside of tensorflow-sys, which includes several packages for building tensorflow. These packages aren't needed for the runtime bindings at all, and this seems like the logical way to separate the two.
|
Hi @adamcrume , could I get some feedback on this when you get a chance? Thanks. |
adamcrume
requested changes
Oct 28, 2022
| ${cmd} | ||
|
|
||
| echo "link! {\n$(cat src/runtime_linking/c_api.rs)" > src/runtime_linking/c_api.rs | ||
| echo } >> src/runtime_linking/c_api.rs |
There was a problem hiding this comment.
All the runtime bits should be removed from tensorflow-sys/generate_bindgen_rs.sh.
|
Sorry for the delay! |
- RELEASING.md now has info about the new tensorflow-sys-runtime crate. - Additional info in the tensorflow-sys-runtime README.md showing how to use it. - Adding the version to tensorflow-sys-runtime in the main Cargo.toml - Removing runtime linking bindgen calls from tensorflow-sys/generate_bindgen_rs.sh
|
@adamcrume Thanks for the review. I've updated the PR with the requested changes, let me know if there's anything else. |
|
Thanks! |
|
@adamcrume Great, thanks for that. Any idea when I can expect a new version to be pushed to crates.io? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime bindings have no use for the the build-dependencies of tensorflow-sys, nor the build.rs. So to avoid pulling in those dependencies, and hopefully to keep things cleaner, I'd like to move them into their own crate.