Skip to content

Update README.md #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 26, 2017
Merged

Update README.md #104

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
158ab05
Update README.md
alanyee Aug 21, 2017
1130da1
Update README.md
alanyee Aug 24, 2017
34ba6f4
Update README.md
alanyee Aug 24, 2017
9e726b1
Update README.md
alanyee Aug 24, 2017
d355958
Update README.md
alanyee Aug 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
[![Status](https://travis-ci.org/tensorflow/rust.svg?branch=master)](https://travis-ci.org/tensorflow/rust)

TensorFlow Rust provides idiomatic [Rust](https://www.rust-lang.org) language
bindings for [TensorFlow](http://tensorflow.org).
bindings for [TensorFlow](https://tensorflow.org).

**Notice:** This project is still under active development and not guaranteed to have a
stable API. This is especially true because the underlying TensorFlow C API has not yet
been stabilized as well.

* [Documentation](https://tensorflow.github.io/rust/tensorflow/)
* [TensorFlow website](http://tensorflow.org)
* [TensorFlow website](https://tensorflow.org)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be https://www.tensorflow.org because of tensorflow/tensorflow#12496.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you know that the certificate expired on June 29?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on your browser, but in Firefox, I get a error page about the connection not being secure. I can then click on Advanced, and it displays the certificate's expiration date.

* [TensorFlow GitHub page](https://github.com/tensorflow/tensorflow)

## Getting Started
Expand Down Expand Up @@ -68,7 +68,7 @@ In short:

1. Install [SWIG](http://www.swig.org) and [NumPy](http://www.numpy.org). The
version from your distro's package manager should be fine for these two.
2. [Install Bazel](http://bazel.io/docs/install.html), which you may need to do
2. [Install Bazel](https://bazel.io/docs/install.html), which you may need to do
from source.
3. `git clone https://github.com/tensorflow/tensorflow`
4. `cd tensorflow`
Expand All @@ -84,11 +84,8 @@ If this is not possible, add `$TENSORFLOW_SRC/bazel-bin/tensorflow` to

You may need to run `ldconfig` to reset `ld`'s cache after copying `libtensorflow.so`.

**OSX Note**: If you are running on OSX, there is a
[Homebrew PR](https://github.com/Homebrew/homebrew-core/pull/10273) in process which, once merged,
will make it easy to install `libtensorflow` wihout hassle. In the meantime, you can take a look at
[snipsco/tensorflow-build](https://github.com/snipsco/tensorflow-build) which provides a homebrew
tap that does essentially the same.
**macOS Note**: Via [Homebrew](https://brew.sh/) in process which, you can just run
`brew install libtensorflow`.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might also want to revisit the Usage section where it is mentioned that TF is built during the crate's build process.

I believe the default now is to download a pre-built (basic CPU only) library instead of full compilation. See https://github.com/tensorflow/rust/blob/f204b39/tensorflow-sys/build.rs#L44-L52.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you rewrite that section? I am unsure what to particularly add or remove.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paragraph's second sentence starts with Since TensorFlow is built during this process... but this sentence is now wrong (after PR #65).

The tensorflow-sys crate's build.rs will either download a pre-built binary (the default) or compile TF if forced to by an environment variable).

The README paragraph could be adapted to mention this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it seem good to you now?

## FAQ's

Expand All @@ -101,16 +98,16 @@ use. See http://doc.crates.io/manifest.html#the-features-section.

## Contributing
Developers and users are welcome to join
[#tensorflow-rust](http://chat.mibbit.com/?server=irc.mozilla.org&channel=%23tensorflow-rust)
[#tensorflow-rust](https://chat.mibbit.com/?server=irc.mozilla.org&channel=%23tensorflow-rust)
on irc.mozilla.org.

See [CONTRIBUTING.md](CONTRIBUTING.md) for information on how to contribute code.
Please read the [contribution guidelines](CONTRIBUTING.md) on how to contribute code.

This is not an official Google product.

RFCs are [issues tagged with RFC](https://github.com/tensorflow/rust/labels/rfc).
Check them out and comment. Discussions are welcome. After all, thats what a Request For
Comment is for!
Check them out and comment. Discussions are welcomed. After all, that is the purpose of
Request For Comment!

## License
This project is licensed under the terms of the [Apache 2.0 license](https://github.com/tensorflow/rust/blob/master/LICENSE).
This project is licensed under the terms of the [Apache 2.0 license](LICENSE).