Skip to content

Improved parameters of SPSA #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improved parameters of SPSA #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7150e53
Update spsa_minimizer.py
lockwo Apr 23, 2023
7e83632
Update spsa_minimizer_test.py
lockwo Apr 23, 2023
06ccfde
Update spsa_minimizer_test.py
lockwo Apr 23, 2023
159affd
Update spsa_minimizer.py
lockwo Apr 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tensorflow_quantum/python/optimizers/spsa_minimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def minimize(expectation_value_function,
tolerance=1e-5,
max_iterations=200,
alpha=0.602,
learning_rate=1.0,
learning_rate=0.31,
perturb=1.0,
gamma=0.101,
blocking=False,
Expand Down Expand Up @@ -277,7 +277,7 @@ def _body(state):
"""Main optimization loop."""
new_learning_rate = learning_rate_init / (
(tf.cast(state.num_iterations + 1, tf.float32) +
0.01 * tf.cast(max_iterations, tf.float32))**state.alpha)
0.1 * tf.cast(max_iterations, tf.float32))**state.alpha)
new_perturb = perturb_init / (tf.cast(state.num_iterations + 1,
tf.float32)**state.gamma)

Expand Down
2 changes: 1 addition & 1 deletion tensorflow_quantum/python/optimizers/spsa_minimizer_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def test_quadratic_function_optimization(self):
func = lambda x: tf.math.reduce_sum(np.power(x, 2) * coefficient)

result = spsa_minimizer.minimize(func, tf.random.uniform(shape=[n]))
self.assertAlmostEqual(func(result.position).numpy(), 0, delta=2e-4)
self.assertAlmostEqual(func(result.position).numpy(), 0, delta=1e-4)
self.assertTrue(result.converged)

def test_noisy_sin_function_optimization(self):
Expand Down