fix compiler errors for modern linux+clang+python+cuda setup #572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(by upgrading cmake and the associated CUDA configuration)
(by using git checkout after submodules are loaded)
(by introducing a lock file)
These changes are tested on my local setup:
using
-DCUDA=ON -DPYTHON=ON
with build typesRelease
andDebug
.BUT THERE WHERE SOME FAILING TESTS!
As I did not change any logic in the code I assume these are not based on my changes but on my setup.
I understand that raising the cmake version is not appreciated by everyone, but modern cmake will not support version lower than 3.10 in the future.
As with 3.18 the CUDA support is improved a lot I upgraded not only to 3.10 but 3.18 which is reasonable in my opinion.