chore: optimize allocation in get_pooled_transaction_elements by pre‑allocating capacity #1766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0xKarl98 is attempting to deploy a commit to the Tempo Team on Vercel. A member of the Team first needs to authorize it. |
mattsse
requested changes
Dec 27, 2025
| .map(|tx| tx.into_inner()) | ||
| }) | ||
| .collect::<Vec<_>>(); | ||
| let mut txs = Vec::with_capacity(tx_hashes.len()); |
Comment on lines
358
to
362
| for tx in self.aa_2d_pool.read().get_all_iter(&tx_hashes) { | ||
| // Safe unwrap: TryFromConsensusError is Infallible for TempoPooledTransaction. | ||
| let pooled = tx.transaction.clone_into_pooled().unwrap(); | ||
| txs.push(pooled.into_inner()); | ||
| } |
Collaborator
There was a problem hiding this comment.
instead of this we could simple flip it and first obtain a vec from
self.protocol_pool
.get_pooled_transaction_elements
and then extend that
if you want you can also submit a pr that adds fn append_pooled_transaction_elements variant for this:
similar to
Author
|
pending @mattsse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims at resolve issue #1764
cc @mattsse