chore: remove no-op protocol-version negotiation in MCP initialize#735
Open
toddfil wants to merge 1 commit into
Open
chore: remove no-op protocol-version negotiation in MCP initialize#735toddfil wants to merge 1 commit into
toddfil wants to merge 1 commit into
Conversation
|
@toddfil is attempting to deploy a commit to the Tempo Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove no-op protocol-version negotiation in MCP initialize
Problem
initializeResultread the client's requestedprotocolVersionfromparams, computed aprotocolVersionlocal, then returned it through a ternary whose two branches are identical:The result is always
PROTOCOL_VERSIONregardless of input, so the entirerequested/protocolVersioncomputation is dead code. It reads as if the server negotiates the version, but it never does.Fix
This server supports exactly one protocol version, so always advertising
PROTOCOL_VERSIONis the correct MCP reply — whether or not the client asked for that same version. The behavior is unchanged; the dead computation and the now-unusedparamsargument are removed, and the call site is updated.The existing
initializetest (index.test.ts) sendsparams: {}and asserts onlyserverInfoandinstructions, so it continues to pass.