replace v5 with crypto.randomuuid #2927
Open
+27
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
GraceGardner
requested review from
Alex-Tideman,
rossedfort and
a team
as code owners
laurakwhit
approved these changes
Oct 1, 2025
src/lib/components/workflow/client-actions/batch-cancel-confirmation-modal.svelte
Outdated
Show resolved
Hide resolved
src/lib/components/workflow/client-actions/batch-reset-confirmation-modal.svelte
Outdated
Show resolved
Hide resolved
src/lib/components/workflow/client-actions/batch-terminate-confirmation-modal.svelte
Outdated
Show resolved
Hide resolved
src/lib/components/workflow/client-actions/update-confirmation-modal.svelte
Outdated
Show resolved
Hide resolved
| randomUUID: () => 'test-uuid-' + Math.random().toString(36).substring(2, 9), | ||
| }; | ||
|
|
||
| vi.stubGlobal('crypto', cryptoMock); |
There was a problem hiding this comment.
Is there a reason you added this mock? Looks like it's currently not being used anywhere.
…mation-modal.svelte Co-authored-by: Laura Whitaker <[email protected]>
…ation-modal.svelte Co-authored-by: Laura Whitaker <[email protected]>
…firmation-modal.svelte Co-authored-by: Laura Whitaker <[email protected]>
…-modal.svelte Co-authored-by: Laura Whitaker <[email protected]>
Co-authored-by: Laura Whitaker <[email protected]>
Co-authored-by: Laura Whitaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Replace v4 with crypto randomUUID
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
Add mock uuid's to account for updated uuid in our tests.
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
dt-3225
Docs
Any docs updates needed?