Add extstore s3 driver#2907
Open
cconstable wants to merge 1 commit into
Open
Conversation
cconstable
commented
Jun 10, 2026
Contributor
Author
|
The actual changes here are only a few hundred lines. The vast majority of the diff is tests, comments, and java ceremony. |
jmaeagle99
reviewed
Jun 11, 2026
cconstable
commented
Jun 12, 2026
| return withFailureContext(uploadRequest, "upload failed " + location); | ||
| }) | ||
| .thenApply(ignored -> claimFor(bucket, key, hexDigest)); | ||
| cancelRequestWhenCancelled(claimFuture, inFlightRequest); |
Contributor
Author
There was a problem hiding this comment.
What I had here previously did not properly cancel the upstream client request. Now cancellation should propagate correctly:
client.objectExists(bucket, key);creates a future that eagerly executes.- that is wrapped in a future that provides failure context via
withFailureContext thenComposechains theclient.putObjectrequestcancelRequestWhenCancelled(claimFuture, inFlightRequest);listens for a cancel onclaimFutureand then reaches upstream and cancels the current inFlightRequest.
If there is a more elegant way to do this in Java please let me know. An alternative solution is returning an opaque cancellation token/context but now you've got two things to cancel and that might be confusing.
cconstable
force-pushed
the
extstore-foundation
branch
from
20914d5 to
4983bfe
Compare
Contributor
Author
|
Merging the old base into master jumbled up the commits in this PR. Doing a rebase --onto and then force pushing to clean this up. |
cconstable
force-pushed
the
extstore-s3-driver
branch
from
3fd31f5 to
9ca30be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
contrib/temporal-payload-storage-s3/src/main/java/io/temporal/payload/storage/s3/PayloadHasherfor drivers to consistently hash payload content.Why?
Checklist