Open
Conversation
cretz
force-pushed
the
spring-4-support
branch
from
a09fdc9 to
8e1021c
Compare
| implementation "org.springframework.boot:spring-boot-starter" | ||
|
|
||
| api project(':temporal-spring-boot-autoconfigure-4') | ||
| api project(':temporal-sdk') |
Contributor
There was a problem hiding this comment.
These should be compileOnly like the original springboot auto-configure is no?
| targetCompatibility = sb4JavaVersion | ||
| } | ||
|
|
||
| // Override the --release 8 flag set by gradle/java.gradle |
Contributor
There was a problem hiding this comment.
Could probably just not set these for this subproject , but this is fine to
| # Temporal Spring Boot | ||
| # Temporal Spring Boot (Spring Boot 2/3) | ||
|
|
||
| > **This module supports Spring Boot 2.7.x and 3.x only.** |
Contributor
There was a problem hiding this comment.
Can we also have an issue to update the docs as well https://docs.temporal.io/develop/java/spring-boot-integration
Contributor
Hmm I still see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
temporal-spring-boot-autoconfigure-4andtemporal-spring-boot-starter-4modules for Spring Boot 4.0.2 support (Java 17+)temporal-spring-boot-shared/src/(not a Gradle module — bothtemporal-spring-boot-autoconfigureandtemporal-spring-boot-autoconfigure-4compile it viasrcDir)@ConfigurationPropertiesclasses inio.temporal.spring.boot.autoconfigure.propertiesare version-specific (@ConstructorBindingremoved for SB4)--release 17andAutoConfiguration.importsonly (nospring.factories)springBoot4Version = '4.0.2'to rootbuild.gradlesettings.gradleandtemporal-bom/build.gradlegradle/linting.gradleto run spotless ontemporal-spring-boot-shared/src/at the root project level (spotless requires targets within the project dir).github/workflows/ci.ymlto exclude SB4 test tasks from theunit_test_jdk8job (-x :temporal-spring-boot-autoconfigure-4:test -x :temporal-spring-boot-starter-4:test) since that job runs on JDK 11.github/workflows/publish-snapshot.ymland.github/workflows/prepare-release.ymlfrom JDK 11 to JDK 17Leans on #2783 (since both are in same fork, hard to target it without forcing PR to be on the fork too, will update when other merged, for now ignore the Jackson 3 parts).
We're going to have to pay attention to publish workflows to make sure they work at release time.
DO NOT MERGE - we are going to wait on Jackson 3 support in #2783 to be merged first.
Checklist