Skip to content

Add DETERMINISTIC_CANCELLATION_SCOPE_ORDER to initial SDK flags#2782

Open
tconley1428 wants to merge 2 commits intomasterfrom
add-deterministic-cancellation-scope-order-to-initial-flags
Open

Add DETERMINISTIC_CANCELLATION_SCOPE_ORDER to initial SDK flags#2782
tconley1428 wants to merge 2 commits intomasterfrom
add-deterministic-cancellation-scope-order-to-initial-flags

Conversation

@tconley1428
Copy link
Contributor

Summary

  • Add DETERMINISTIC_CANCELLATION_SCOPE_ORDER to WorkflowStateMachines.initialFlags to enable deterministic cancellation scope ordering by default for all new workflow executions
  • Add backward compatibility test that validates workflows started before the flag was added can replay correctly without NDE issues
  • Remove problematic setUp() method that was causing test interference when running multiple tests together

Test plan

  • All existing tests pass
  • New backward compatibility test passes both individually and when run with other tests
  • Verified no test interference issues after removing setUp() method
  • Validated workflow history recorded without the flag can replay successfully with the flag enabled

🤖 Generated with Claude Code

- Add DETERMINISTIC_CANCELLATION_SCOPE_ORDER to WorkflowStateMachines.initialFlags to enable deterministic cancellation scope ordering by default for all new workflow executions
- Add backward compatibility test that validates workflows started before the flag was added can still replay correctly without NDE issues
- Remove problematic setUp() method that was causing test interference when running multiple tests together
- Add workflow history file recorded without the flag for backward compatibility testing

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@tconley1428 tconley1428 requested a review from a team as a code owner February 11, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant