Add support for parameterized and generic types in DataConverter (#2413) #2605
Conversation
|
Thanks, I think this makes sense. Can we add a test to verify the reported issue is now resolved? I think we just need to have a workflow with the following signature |
| * @return the raw Class for the type | ||
| */ | ||
| static Class<?> getRawClass(Type type) { | ||
| if (type instanceof Class) { |
There was a problem hiding this comment.
Do we need to handle any other type? I might just need to test but isn't GenericArrayType possible as well?
There was a problem hiding this comment.
Good catch regarding GenericArrayType - I've added support for that as well now.
|
@Quinn-With-Two-Ns added specific test you mentioned to |
| * @param type the Type to extract from (could be Class, ParameterizedType, or GenericArrayType) | ||
| * @return the raw Class for the type | ||
| */ | ||
| static Class<?> getRawClass(Type type) { |
There was a problem hiding this comment.
Also don't shouldn't expose this on the data converter interface, this is an implementation detail and should not be part of the public API
|
Found a better way to handle these edge cases |
Proposal to resolve #2413