Wait for RoutingConfigPropagation to complete to fix failing/flaky tests#748
Merged
kepe-temporal merged 1 commit intomainfrom Feb 6, 2026
Merged
Wait for RoutingConfigPropagation to complete to fix failing/flaky tests#748kepe-temporal merged 1 commit intomainfrom
kepe-temporal merged 1 commit intomainfrom
Conversation
Shivs11
commented
Feb 6, 2026
| BuildID: version.BuildID, | ||
| ConflictToken: response1.ConflictToken, | ||
| Percentage: float32(100.0), | ||
| Percentage: percentage, |
Member
Author
There was a problem hiding this comment.
think this was just an unrelated bug that I noticed......we were passing in percentage but never really using it
Shivs11
commented
Feb 6, 2026
| } | ||
| state := resp.GetWorkerDeploymentInfo().GetRoutingConfigUpdateState() | ||
| return state == enumspb.ROUTING_CONFIG_UPDATE_STATE_COMPLETED || | ||
| state == enumspb.ROUTING_CONFIG_UPDATE_STATE_UNSPECIFIED |
Member
Author
There was a problem hiding this comment.
reason why we also return true for Unspecified here is that if this is ran against a server that does not use async versioning workflows, we just want this condition to pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
How was this tested: