docs: restore TypeScript external storage snippets - #5217
Draft
lennessyy wants to merge 2 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📖 Docs PR preview links
|
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The custom snippets still depend on the unmerged draft samples-typescript#503, preventing final main-branch verification.
Pull request overview
Restores Snipsync-backed TypeScript External Storage examples and source references.
Changes:
- Restores source links for S3, GCS, setup, threshold, and multiple-driver snippets.
- Adds filesystem-driver and Data Converter snippets from the pending sample PR.
File summaries
| File | Description |
|---|---|
docs/develop/typescript/best-practices/data-handling/external-storage.mdx |
Restores and adds TypeScript External Storage snippets. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency
This PR remains a draft until temporalio/samples-typescript#503 merges. The custom snippets are generated from that PR branch; their source markers will resume syncing from
mainafter the sample is merged.Validation
yarn snipsync(targeted synchronization with the samples PR branch)vale --config .vale-ci.ini docs/develop/typescript/best-practices/data-handling/external-storage.mdxyarn build