Skip to content

fix: support multiple -input flags in gen-docs#940

Merged
chaptersix merged 4 commits intotemporalio:mainfrom
chaptersix:fix/gen-docs-multiple-inputs
Feb 7, 2026
Merged

fix: support multiple -input flags in gen-docs#940
chaptersix merged 4 commits intotemporalio:mainfrom
chaptersix:fix/gen-docs-multiple-inputs

Conversation

@chaptersix
Copy link
Contributor

Summary

  • Add stringSlice flag type to support multiple -input flags (standard flag package only keeps the last value)
  • Pass inputs separately to ParseCommands which already supports variadic args
  • Add test for multi-input generation
  • Update CI to use make targets instead of raw commands

Test plan

  • go test ./cmd/gen-docs/... passes
  • make gen-docs generates docs correctly with both input files

Fixes the broken invocation where -input was specified twice but only the last file was used.

Copy link
Contributor

@stephanos stephanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(approved with understanding that make change is reverted)

@chaptersix chaptersix merged commit c62e234 into temporalio:main Feb 7, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants