fix: support multiple -input flags in gen-docs#940
Merged
chaptersix merged 4 commits intotemporalio:mainfrom Feb 7, 2026
Merged
fix: support multiple -input flags in gen-docs#940chaptersix merged 4 commits intotemporalio:mainfrom
chaptersix merged 4 commits intotemporalio:mainfrom
Conversation
Merged
1 task
stephanos
approved these changes
Feb 6, 2026
Contributor
stephanos
left a comment
There was a problem hiding this comment.
(approved with understanding that make change is reverted)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stringSliceflag type to support multiple-inputflags (standardflagpackage only keeps the last value)ParseCommandswhich already supports variadic argsmaketargets instead of raw commandsTest plan
go test ./cmd/gen-docs/...passesmake gen-docsgenerates docs correctly with both input filesFixes the broken invocation where
-inputwas specified twice but only the last file was used.