Add durable-timer sleep step to DSL workflow - #26
Merged
Conversation
Add a 't' (SleepSeconds) field to DSLStep so a DSL workflow can sleep directly via workflow.Sleep (a durable timer) instead of invoking the Sleep activity. This lets the benchmark exercise workflow-timer sleeps, not just Sleep activities. The field is optional and backward compatible (0 = no-op) and respects the existing repeat semantics.
prathyushpv
marked this pull request as ready for review
July 16, 2026 23:42
robholland
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Enable durable-timer sleep in the DSL workflow so benchmarks can exercise workflow-timer sleeps (
workflow.Sleep), not just theSleepactivity.What
Add an optional
t(SleepSeconds) field toDSLStep. Whent > 0, the interpreter callsworkflow.Sleep(ctx, t*time.Second)— a durable timer, no activity. Optional and backward compatible (omitempty, 0 = no-op); respects the existingrrepeat semantics.Example:
[{"t": 1}, {"a": "Echo", "i": {"Message": "test"}}, {"t": 5}]Adds a unit test (
TestDSLWorkflowWithTimerSleep) asserting the workflow completes and the test env fast-forwards the durable timers. README DSL field list and examples updated.