Skip to content

Conversation

@rkannan82
Copy link

@rkannan82 rkannan82 commented Feb 9, 2026

What changed?

Added worker_control_task_queue to poll requests:

Added worker_instance_key and worker_control_task_queue to:

  • RespondWorkflowTaskCompletedRequest: This API is used to eagerly fetch activity.

Why?
To enable server to send nexus tasks to worker.
Example use case:

  • User cancels a workflow.
  • Server sends activity cancellation tasks to all workers that could be processing activities belonging to the workflow.

Breaking changes: None
Server PR

@rkannan82 rkannan82 requested review from a team as code owners February 9, 2026 19:18
@rkannan82 rkannan82 force-pushed the kannan/add-worker-instance-key-to-wft-complete branch from 76cff4d to d940f4e Compare February 9, 2026 19:18
@rkannan82 rkannan82 marked this pull request as draft February 9, 2026 19:20
@rkannan82 rkannan82 marked this pull request as ready for review February 9, 2026 19:28
@rkannan82 rkannan82 force-pushed the kannan/add-worker-instance-key-to-wft-complete branch from d940f4e to 6fb0a9a Compare February 11, 2026 02:33
@rkannan82 rkannan82 changed the title Add worker_instance_key to RespondWorkflowTaskCompletedRequest Add attributes needed by server to propagate nexus tasks to worker Feb 11, 2026
@rkannan82 rkannan82 requested a review from cretz February 11, 2026 02:54
@rkannan82 rkannan82 force-pushed the kannan/add-worker-instance-key-to-wft-complete branch from 6fb0a9a to 3425c98 Compare February 11, 2026 02:55
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No big blockers, though I noticed the "Server PR" section of the PR template was removed from the description of this PR. I do think we should wait for most of server impl to understand this has everything needed (no use merging before then).

@rkannan82 rkannan82 force-pushed the kannan/add-worker-instance-key-to-wft-complete branch from 98f7a60 to 61952c9 Compare February 11, 2026 21:20
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but mentioned in last review, the "Server PR" section removed from description template, would like to see implementation get a bit further and linked if possible

@rkannan82
Copy link
Author

No big blockers, though I noticed the "Server PR" section of the PR template was removed from the description of this PR. I do think we should wait for most of server impl to understand this has everything needed (no use merging before then).

Chad, How can I make progress on the server PRs without submitting this API change? I might have asked this before, but what is the recommended protocol? Should I have started the server PRs in my own repo (forked) and have that reference this unsubmitted

LGTM, but mentioned in last review, the "Server PR" section removed from description template, would like to see implementation get a bit further and linked if possible

I added the server PR to the description. temporalio/temporal#9231

@rkannan82 rkannan82 requested a review from cretz February 12, 2026 18:59
This enables the server to track which worker is executing eager-dispatched
activities, allowing activity cancellation to be routed correctly.
@rkannan82 rkannan82 force-pushed the kannan/add-worker-instance-key-to-wft-complete branch from 61952c9 to 98350a9 Compare February 12, 2026 19:46
@cretz
Copy link
Member

cretz commented Feb 12, 2026

Should I have started the server PRs in my own repo (forked) and have that reference this unsubmitted

Yeah, basically this. It just means you have a PR mostly done but referencing your API branch instead of API master. It's just a good way to make sure we don't "oh yeah" during implementation (even when we think we're so sure what we want from he API). May be able to ask server peers on common approach here, e.g. feature branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants