Use Temporal failures in Nexus APIs #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
approved these changes
Dec 5, 2025
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
LGTM, assuming that this won't be merged until it's proven to work.
4 tasks
This was referenced Jan 5, 2026
temporal/api/nexus/v1/message.proto
Outdated
Comment on lines
130
to
131
| // The operation completed unsuccessfully (failed or canceled). | ||
| UnsuccessfulOperationError operation_error = 3; |
Contributor
There was a problem hiding this comment.
Should we mark this as deprecated?
| Async async_success = 2; | ||
| // The operation completed unsuccessfully (failed or canceled). | ||
| UnsuccessfulOperationError operation_error = 3; | ||
| // Deprecated. Use the failure variant instead. |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| // Deprecated. Use the failure variant instead. | |
| // Deprecated. Use the failure variant instead if temporal_failure_responses was true on the request. |
Quinn-With-Two-Ns
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added Temporal failure representations for Nexus errors.
Why?
Consistency with other Temporal APIs and to make it easier to handle payloads.
Breaking changes
Not explicitly, but server and SDK will need to be able to handle both error formats based on
capabilitiesfield.Server PR
temporalio/temporal#8799