Skip to content

feat: add wildcard suport for repository#2734

Open
johnvox wants to merge 1 commit into
tektoncd:mainfrom
johnvox:feat-wildcard-repository-url
Open

feat: add wildcard suport for repository#2734
johnvox wants to merge 1 commit into
tektoncd:mainfrom
johnvox:feat-wildcard-repository-url

Conversation

@johnvox
Copy link
Copy Markdown

@johnvox johnvox commented May 16, 2026

📝 Description of the Change

This change introduce posibility to match repository over glob or regex pattern making able to setup a single repository cr to handle set of repositories

🔗 Linked GitHub Issue

Fixes #1246

🧪 Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing

🤖 AI Assistance

AI assistance can be used for various tasks, such as code generation,
documentation, or testing.

Please indicate whether you have used AI assistance
for this PR and provide details if applicable.

  • I have not used any AI assistance for this PR.
  • I have used AI assistance for this PR.

Important

Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Claude noreply@anthropic.com

✅ Submitter Checklist

  • 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • ♽ I have run make test and make lint locally to check for and fix any
    issues. For an efficient workflow, I have considered installing
    pre-commit and running pre-commit install to
    automate these checks.
  • 📖 I have added or updated documentation for any user-facing changes.
  • 🧪 I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
  • If adding a provider feature, I have filled in the following and updated the provider documentation:
    • GitHub App
    • GitHub Webhook
    • Gitea/Forgejo
    • GitLab
    • Bitbucket Cloud
    • Bitbucket Data Center

@johnvox johnvox marked this pull request as ready for review May 16, 2026 05:43
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces glob pattern matching for repository URLs in MatchEventURLRepo through a new matchRepo helper function, along with comprehensive test coverage for various glob patterns. Feedback was provided to improve the robustness of the matching logic by prioritizing exact matches over wildcards, handling glob compilation errors gracefully, and employing more thorough URL normalization techniques like strings.TrimRight and strings.TrimSpace to handle multiple trailing slashes or whitespace.

Comment on lines 26 to 35
for _, repo := range repositories.Items {
repo.Spec.URL = strings.TrimSuffix(repo.Spec.URL, "/")
if repo.Spec.URL == event.URL {
match, err := matchRepo(event.URL, repo.Spec.URL)
if err != nil {
return nil, err
}
if match {
return &repo, nil
}
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The current matching logic has several issues that should be addressed to ensure robustness and security:

  1. Priority: Exact matches should always take precedence over wildcard matches.
  2. Error Handling: Invalid glob patterns should be skipped instead of terminating the process.
  3. URL Normalization: When comparing repository URLs, use a robust normalization method like strings.TrimRight and strings.TrimSpace to handle multiple trailing slashes or spaces, as strings.TrimSuffix only removes a single trailing character.
  4. Loop Variable: Access the element by index to avoid issues with loop variables.

Suggested improvement using a two-pass approach to prioritize exact matches and handle errors gracefully:

	for i := range repositories.Items {
		repo := &repositories.Items[i]
		if strings.TrimRight(strings.TrimSpace(repo.Spec.URL), "/") == event.URL {
			return repo, nil
		}
	}
	for i := range repositories.Items {
		repo := &repositories.Items[i]
		if match, err := matchRepo(event.URL, repo.Spec.URL); err == nil && match {
			return repo, nil
		}
	}
References
  1. When comparing repository URLs, use a robust normalization method like strings.TrimRight and strings.TrimSpace to handle multiple trailing slashes or spaces, as strings.TrimSuffix only removes a single trailing character.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow wildcard URL matching in repository CR

1 participant