Skip to content

Commit

Permalink
build: fix cross-platform android builds on OS X (google#237)
Browse files Browse the repository at this point in the history
  • Loading branch information
alyssawilk authored Nov 3, 2022
1 parent c674330 commit 5417654
Showing 1 changed file with 4 additions and 23 deletions.
27 changes: 4 additions & 23 deletions BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,6 @@

licenses(["notice"])

config_setting(
name = "osx",
constraint_values = [
"@platforms//os:osx",
],
)

config_setting(
name = "ios",
constraint_values = [
"@platforms//os:ios",
],
)

### libraries

cc_library(
Expand Down Expand Up @@ -66,15 +52,10 @@ cc_library(
"include/cctz/zone_info_source.h",
],
includes = ["include"],
linkopts = select({
"//:osx": [
"-framework Foundation",
],
"//:ios": [
"-framework Foundation",
],
"//conditions:default": [],
}),
# OS X and iOS no longer use `linkopts = ["-framework CoreFoundation"]`
# as (1) bazel adds it automatically, and (2) it caused problems when
# cross-compiling for Android.
# See https://github.com/abseil/abseil-cpp/issues/326 for details.
visibility = ["//visibility:public"],
deps = [":civil_time"],
)
Expand Down

0 comments on commit 5417654

Please sign in to comment.