Fix db transfers test login #121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hand side expression is true, the OR expression returns true without executing the right hand side expression. This is called short circuiting. Using OR operation in this test will secceed even if the right hand side is false. This commit exchange the OR with AND expression which requires both left and right hand sides to be true which is the correct logic for this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way Golang process logical OR operation is that, if the left
hand side expression is true, the OR expression returns true
without executing the right hand side expression. This is called
short circuiting.
Using OR operation in this test will secceed even if the right
hand side is false.
This commit exchange the OR with AND expression which requires
both left and right hand sides to be true which is the correct
logic for this test.