test: trim redundant e2e tests, move pure logic to unit specs

e2e/commands/add.e2e.ts

@@ -3,10 +3,8 @@ import chai, { expect } from 'chai';
 import fs from 'fs-extra';
 import * as path from 'path';
 import { OutsideWorkspaceError } from '@teambit/workspace';
-import { InvalidName } from '@teambit/legacy-bit-id';
 import { statusInvalidComponentsMsg } from '@teambit/legacy.constants';
 import { MainFileIsDir, PathOutsideConsumer, VersionShouldBeRemoved } from '@teambit/tracker';
-import { MissingMainFile } from '@teambit/legacy.bit-map';
 import { Helper } from '@teambit/legacy.e2e-helper';
 import chaiFs from 'chai-fs';
 import assertArrays from 'chai-arrays';
@@ -69,34 +67,11 @@ describe('bit add command', function () {
       const bitMap = helper.bitMap.read();
       expect(bitMap).to.have.property('test/bar');
     });
-    it('Should throw error when no index file is found', () => {
-      const file1 = 'foo1.js';
-      const file2 = 'foo2.js';
-      helper.fs.createFile('bar', file1);
-      helper.fs.createFile('bar', file2);
-
-      const addCmd = () => helper.command.addComponent('bar', { n: 'test' });
-      // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
-      const error = new MissingMainFile(`${helper.scopes.remote}/test/bar`);
-      helper.general.expectToThrow(addCmd, error);
-    });
     it('Should throw error msg if -i and -n flag are used with bit add', () => {
       helper.fs.createFile('bar', 'foo2.js');
       const addCmd = () => helper.command.addComponent('bar', { n: 'test', i: 'jaja' });
       expect(addCmd).to.throw('please use either [id] or [namespace] to add a particular component');
     });
-    it('Should prevent adding a file with invalid keys in namespace', () => {
-      const error = new InvalidName('bar.f/foo');
-      helper.fixtures.createComponentBarFoo();
-      const addFunc = () => helper.command.addComponent('bar', { i: 'bar.f/foo' });
-      helper.general.expectToThrow(addFunc, error);
-    });
-    it('Should prevent adding a file with invalid keys in ID', () => {
-      const error = new InvalidName('bar/fo.o');
-      helper.fixtures.createComponentBarFoo();
-      const addFunc = () => helper.command.addComponent('bar', { i: 'bar/fo.o' });
-      helper.general.expectToThrow(addFunc, error);
-    });
     it('Define dynamic main file ', () => {
       const mainFileOs = path.normalize('{PARENT}/{PARENT}.js');
       helper.fs.createFile('bar', 'bar.js');
@@ -107,12 +82,6 @@ describe('bit add command', function () {
       const mainFile = bitMap['test/bar'].mainFile;
       expect(mainFile).to.equal('bar.js');
     });
-    it('Should return error if used an invalid ID', () => {
-      helper.fs.createFile('bar', 'foo.js');
-      const addFunc = () => helper.command.addComponent('bar', { i: 'Bar/foo' });
-      const error = new InvalidName('Bar/foo');
-      helper.general.expectToThrow(addFunc, error);
-    });
     it('should add component with id contains only one level', () => {
       helper.fs.createFile('bar', 'foo.js');
       helper.command.addComponent('bar', {
@@ -122,20 +91,6 @@ describe('bit add command', function () {
       expect(bitMap).to.have.property('foo');
     });
   });
-  describe('with multiple index files', () => {
-    before(() => {
-      helper.scopeHelper.reInitWorkspace();
-      helper.fs.createFile('bar', 'index.js');
-      helper.fs.createFile('bar', 'foo.js');
-      helper.fs.createFile(path.join('bar', 'exceptions'), 'some-exception.js');
-      helper.fs.createFile(path.join('bar', 'exceptions'), 'index.js');
-      helper.command.addComponent('bar', { i: 'bar/foo' });
-    });
-    it('should identify the closest index file as the main file', () => {
-      const bitMap = helper.bitMap.read();
-      expect(bitMap['bar/foo'].mainFile).to.equal('index.js');
-    });
-  });
   describe('add component/s with gitignore', () => {
     let errorMessage;
     before(() => {
@@ -155,22 +110,14 @@ describe('bit add command', function () {
     });
   });
   describe('ignore specific files inside component', () => {
-    let output;
     before(() => {
       helper.scopeHelper.reInitWorkspace();
       helper.fs.createFile('bar', 'foo.js');
       helper.fs.createFile('bar', 'foo3.js');
       helper.fs.createFile('bar', 'boo.js');
       helper.fs.createFile('bar', 'index.js');
       helper.git.writeGitIgnore(['bar/foo.js', 'bar/foo3.js']);
-      output = helper.command.addComponent(path.normalize('bar'), { i: 'bar/foo' });
-    });
-    it('Should track component ', () => {
-      expect(output).to.contain('bar/foo');
-    });
-    it('Should contain component inside bitmap', () => {
-      const bitMap = helper.bitMap.read();
-      expect(bitMap).to.have.property('bar/foo');
+      helper.command.addComponent(path.normalize('bar'), { i: 'bar/foo' });
     });
     it('Should contain inside bitmap only files that are not inside gitignore', () => {
       const files = helper.command.getComponentFiles('bar/foo');
@@ -258,38 +205,4 @@ describe('bit add command', function () {
       helper.general.expectToThrow(addCmd, error);
     });
   });
-  describe('no mainFile and one of the files has the same name as the directory', () => {
-    before(() => {
-      helper.scopeHelper.reInitWorkspace();
-      helper.fs.createFile('bar', 'bar.js');
-      helper.fs.createFile('bar', 'foo.js');
-      helper.command.addComponent('bar');
-    });
-    it('should resolve the mainFile as the file with the same name as the directory', () => {
-      const bitMap = helper.bitMap.read();
-      const bar = bitMap.bar;
-      expect(bar.mainFile).to.equal('bar.js');
-    });
-  });
-  describe('sort .bitmap components', () => {
-    before(() => {
-      helper.scopeHelper.reInitWorkspace();
-      helper.fs.createFileOnRootLevel('aaa/aaa.js');
-      helper.fs.createFileOnRootLevel('bbb/bbb.js');
-      helper.fs.createFileOnRootLevel('ccc/ccc.js');
-      helper.fs.createFileOnRootLevel('ddd/ddd.js');
-      helper.command.addComponent('bbb');
-      helper.command.addComponent('ddd');
-      helper.command.addComponent('aaa');
-      helper.command.addComponent('ccc');
-    });
-    it('should sort the components in .bitmap file alphabetically', () => {
-      const bitMap = helper.bitMap.read();
-      const ids = Object.keys(bitMap);
-      expect(ids[0]).to.equal('aaa');
-      expect(ids[1]).to.equal('bbb');
-      expect(ids[2]).to.equal('ccc');
-      expect(ids[3]).to.equal('ddd');
-    });
-  });
 });

e2e/commands/config.e2e.ts

@@ -40,28 +40,6 @@ describe('bit config', function () {
     });
   });
 
-  describe('git propagation', () => {
-    before(() => {
-      helper.scopeHelper.reInitWorkspace();
-      helper.git.initNewGitRepo();
-      helper.command.runCmd('bit config set conf.key bit-value');
-      // Commented because of permission issue
-      // helper.git.addGitConfig('conf.key', 'git-system-val', 'system');
-      helper.git.addGitConfig('conf.key', 'git-global-val', 'global');
-      helper.git.addGitConfig('conf.key', 'git-local-val', 'local');
-    });
-    it('should read config from bit if exists', () => {
-      const confVal = helper.command.runCmd('bit config get conf.key');
-      expect(confVal).to.have.string('bit-value\n');
-    });
-    it('should not throw an error if not exists both in git and bit', () => {
-      // const confVal = helper.command.runCmd('bit config get nonExistsKey');
-      // expect(confVal).to.be.oneOf(['\n', '', 'undefined\n']);
-      const getNonExistConf = () => helper.command.runCmd('bit config get nonExistsKey');
-      expect(getNonExistConf).to.not.throw();
-    });
-  });
-
   describe('saving config in the local workspace', () => {
     before(() => {
       helper.scopeHelper.reInitWorkspace();

e2e/commands/diff.e2e.ts

@@ -217,41 +217,6 @@ describe('bit diff command', function () {
         expect(diffOfVersionOutput).to.be.equal(output);
       });
     });
-    describe('running bit diff between current version and version 0.0.1', () => {
-      before(() => {
-        helper.command.tagAllComponents(undefined, undefined, false);
-        output = helper.command.diff('bar/foo 0.0.1');
-      });
-      it('should indicate the deleted files as deleted', () => {
-        expect(output).to.have.string(`--- ${barFooFile} (0.0.1)`);
-        expect(output).to.have.string(`+++ ${barFooFile} (0.0.2)`);
-        expect(output).to.have.string(`-${barFooV1}`);
-      });
-      it('should indicate the added files as added', () => {
-        const barFoo2File = 'foo2.js';
-        expect(output).to.have.string(`--- ${barFoo2File} (0.0.1)`);
-        expect(output).to.have.string(`+++ ${barFoo2File} (0.0.2)`);
-        expect(output).to.have.string(`+${barFooV2}`);
-      });
-      describe('other fields diff', () => {
-        it('should indicate that the mainFile was changed', () => {
-          expect(output).to.have.string('--- Main File (0.0.1)');
-          expect(output).to.have.string('+++ Main File (0.0.2)');
-          expect(output).to.have.string('- foo.js');
-          expect(output).to.have.string('+ foo2.js');
-        });
-        it('should indicate that the files array were changed', () => {
-          expect(output).to.have.string('--- Files (0.0.1)');
-          expect(output).to.have.string('+++ Files (0.0.2)');
-          expect(output).to.have.string('- [ foo.js ]');
-          expect(output).to.have.string('+ [ foo2.js ]');
-        });
-      });
-      it('should have the same output as running diff of the previous version', () => {
-        const diffOfVersionOutput = helper.command.diff('bar/foo 0.0.1');
-        expect(diffOfVersionOutput).to.be.equal(output);
-      });
-    });
   });
   describe('component with multiple versions', () => {
     before(() => {

e2e/commands/export.e2e.ts

@@ -215,7 +215,7 @@ describe('bit export command', function () {
         expect(list).to.have.lengthOf(1);
       });
     });
-    describe('export with --all flag', () => {
+    describe('export with --all-versions flag', () => {
       before(() => {
         helper.scopeHelper.reInitRemoteScope();
         helper.command.export(`${helper.scopes.remote} ${helper.scopes.remote}/* --all-versions`);

e2e/commands/import.e2e.ts

@@ -157,70 +157,6 @@ describe('bit import', function () {
             expect(componentFileLocation).to.be.a.file();
           });
         });
-        describe('when the destination is an existing empty directory', () => {
-          before(() => {
-            helper.scopeHelper.reInitWorkspace();
-            helper.scopeHelper.addRemoteScope();
-            fs.ensureDirSync(path.join(helper.scopes.localPath, 'my-custom-location'));
-            helper.command.runCmd(`bit import ${helper.scopes.remote}/global/simple -p my-custom-location`);
-          });
-          it('should write the component to the specified path', () => {
-            expect(componentFileLocation).to.be.a.file();
-          });
-        });
-        describe('when the destination directory is not empty', () => {
-          let output;
-          let existingFile;
-          before(() => {
-            existingFile = path.join(helper.scopes.localPath, 'my-custom-location/my-file.js');
-            helper.scopeHelper.reInitWorkspace();
-            helper.scopeHelper.addRemoteScope();
-            fs.ensureDirSync(path.join(helper.scopes.localPath, 'my-custom-location'));
-            fs.outputFileSync(existingFile, 'console.log()');
-            output = helper.general.runWithTryCatch(
-              `bit import ${helper.scopes.remote}/global/simple -p my-custom-location`
-            );
-          });
-          it('should not import the component', () => {
-            expect(componentFileLocation).to.not.be.a.path();
-          });
-          it('should not delete the existing file', () => {
-            expect(existingFile).to.be.a.file();
-          });
-          it('should throw an error', () => {
-            expect(output).to.have.string('unable to import');
-          });
-          it('should import successfully if the --override flag is used', () => {
-            helper.command.runCmd(`bit import ${helper.scopes.remote}/global/simple -p my-custom-location --override`);
-            expect(componentFileLocation).to.be.a.file();
-          });
-        });
-        describe('when the destination is a file', () => {
-          let output;
-          before(() => {
-            helper.scopeHelper.reInitWorkspace();
-            helper.scopeHelper.addRemoteScope();
-            fs.outputFileSync(path.join(helper.scopes.localPath, 'my-custom-location'), 'console.log()');
-            output = helper.general.runWithTryCatch(
-              `bit import ${helper.scopes.remote}/global/simple -p my-custom-location`
-            );
-          });
-          it('should not import the component', () => {
-            expect(componentFileLocation).to.not.be.a.path();
-          });
-          it('should not delete the existing file', () => {
-            expect(path.join(helper.scopes.localPath, 'my-custom-location')).to.be.a.file();
-          });
-          it('should throw an error', () => {
-            expect(output).to.have.string('unable to import');
-          });
-          it('should throw an error also when the --override flag is used', () => {
-            output = helper.general.runWithTryCatch(
-              `bit import ${helper.scopes.remote}/global/simple -p my-custom-location --override`
-            );
-            expect(output).to.have.string('unable to import');
-          });
-        });
       });
     });
 
@@ -544,24 +480,12 @@ describe('bit import', function () {
         expect(output).to.have.string('--dependencies-depth');
         expect(output).to.have.string('--dependencies');
       });
-      it('should error when --dependencies-depth is zero', () => {
+      it('should error when --dependencies-depth is not a positive integer', () => {
         const output = helper.general.runWithTryCatch(
           `bit import ${helper.scopes.remote}/comp1 --dependencies --dependencies-depth 0`
         );
         expect(output).to.have.string('positive integer');
       });
-      it('should error when --dependencies-depth is a non-integer', () => {
-        const output = helper.general.runWithTryCatch(
-          `bit import ${helper.scopes.remote}/comp1 --dependencies --dependencies-depth abc`
-        );
-        expect(output).to.have.string('positive integer');
-      });
-      it('should error when --dependencies-depth is a fractional number', () => {
-        const output = helper.general.runWithTryCatch(
-          `bit import ${helper.scopes.remote}/comp1 --dependencies --dependencies-depth 1.5`
-        );
-        expect(output).to.have.string('positive integer');
-      });
     });
   });
   describe('external package manager mode', () => {