Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call State as Connecting until RTCIceConnectionState.RTCIceConnectionStateConnected #107

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Call State as Connecting until RTCIceConnectionState.RTCIceConnectionStateConnected #107

merged 7 commits into from
Feb 12, 2025
+27 −17

Conversation

Oliver-Zimmerman
Copy link
Collaborator

@Oliver-Zimmerman Oliver-Zimmerman commented Feb 11, 2025 •
edited
Loading

WEBRTC-2485 - Call State as Connecting until voice ID message received.

👴 👶 Behaviors

Before changes

  • Call became active as soon as it was answered, despite no audio flow
  • Login with token not updating state on app side

After changes

  • Call stays as connecting until we receive RTCIceConnectionState.RTCIceConnectionStateConnected
  • Adjustments on App Side to show connecting UI state when answering a Push Notification
  • Observing responses and updating state when logging in with token

✋ Manual testing

  1. Receive call
  2. Answer
  3. Should show loading dialog until actually connected

@Oliver-Zimmerman Oliver-Zimmerman marked this pull request as ready for review February 11, 2025 16:03
@Oliver-Zimmerman Oliver-Zimmerman mentioned this pull request Feb 11, 2025
Closed
9 tasks
@Oliver-Zimmerman Oliver-Zimmerman changed the title Call State as Connecting until voice ID message received Call State as Connecting until RTCIceConnectionState.RTCIceConnectionStateConnected Feb 11, 2025
@Oliver-Zimmerman Oliver-Zimmerman merged commit 7b43088 into main Feb 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojciechowskiradek wojciechowskiradek wojciechowskiradek approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oliver-Zimmerman @wojciechowskiradek