Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flutter Web Adjustments #105

Merged
merged 11 commits into from
Feb 10, 2025
Merged

Flutter Web Adjustments #105

merged 11 commits into from
Feb 10, 2025

Conversation

Oliver-Zimmerman
Copy link
Collaborator

@Oliver-Zimmerman Oliver-Zimmerman commented Feb 9, 2025 •
edited
Loading

ENGDESK-38133 - Flutter Web Adjustments.

👴 👶 Behaviors

Before changes

  • Issues with Flutter Web not working correctly

After changes

  • Adjust Flutter Web to work properly (import path replacement)
  • Add necessary checks on app side to utilize web properly
  • Add icons, etc for web deployment
  • use URLS structure rather than single URL in peer connection (fixes safari on iPad / iPhone)

✋ Manual testing

  1. Use hosted flutter client (currently internal URL)

@Oliver-Zimmerman Oliver-Zimmerman marked this pull request as ready for review February 10, 2025 13:50
gbattistel
gbattistel approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@gbattistel gbattistel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Brave browser and it seems to be working fine I was able to make and receive calls.

@Oliver-Zimmerman Oliver-Zimmerman merged commit 23a05c1 into main Feb 10, 2025
4 checks passed
@Oliver-Zimmerman Oliver-Zimmerman deleted the ENGDESK-38133 branch February 10, 2025 14:01
@Oliver-Zimmerman Oliver-Zimmerman mentioned this pull request Feb 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbattistel gbattistel gbattistel approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oliver-Zimmerman @gbattistel