Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle TokenConfig reconnection for PushNotifications #102

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Handle TokenConfig reconnection for PushNotifications #102

merged 3 commits into from
Feb 7, 2025

Conversation

Oliver-Zimmerman
Copy link
Collaborator

@Oliver-Zimmerman Oliver-Zimmerman commented Feb 7, 2025 •
edited
Loading

ENGDESK-38173 - Handle TokenConfig reconnection for PushNotifications .

👴 👶 Behaviors

Before changes

  • We were only handle CredentialConfigs when reconnecting to the TelnyxClient as a result of a push notification in the sample app, meaning people using TokenConfigs could not log back in to receive the call.

After changes

  • We now handle both Credential and Token Configs when reconnecting as a result of a push notification in the sample app.

✋ Manual testing

  1. Launch app
  2. Register with Token
  3. Login
  4. Logout
  5. Call and receive push notification + reconnect and connect to call
  6. Retest flow with Credential Config as well.

@Oliver-Zimmerman Oliver-Zimmerman mentioned this pull request Feb 7, 2025
Closed
@Oliver-Zimmerman Oliver-Zimmerman merged commit 1e7e608 into main Feb 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacakakpo1 isaacakakpo1 isaacakakpo1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oliver-Zimmerman @isaacakakpo1