fix: guard for null issues in stats + bump SDK version

team-telnyx · Feb 9, 2025 · ccb96ed · ccb96ed
1 parent 1e7e608
commit ccb96ed
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 12 deletions.
diff --git a/packages/telnyx_webrtc/lib/utils/stats/webrtc_stats_reporter.dart b/packages/telnyx_webrtc/lib/utils/stats/webrtc_stats_reporter.dart
@@ -1,7 +1,6 @@
 import 'dart:async';
 import 'dart:collection';
 import 'dart:convert';
-import 'dart:io';
 import 'package:flutter_webrtc/flutter_webrtc.dart';
 import 'package:logger/logger.dart';
 import 'package:telnyx_webrtc/utils/stats/stats_parsing_helpers.dart';
@@ -131,20 +130,34 @@ class WebRTCStatsReporter {
         );
       }
       ..onSignalingState = (RTCSignalingState signalingState) async {
-        final localSdp = await peerConnection.getLocalDescription();
-        final remoteSdp = await peerConnection.getRemoteDescription();
+        RTCSessionDescription? localSdp;
+        RTCSessionDescription? remoteSdp;
+
+        try {
+          localSdp = await peerConnection.getLocalDescription();
+          remoteSdp = await peerConnection.getRemoteDescription();
+        } catch (e) {
+          _logger.e('Error retrieving descriptions for Signaling State Stats: $e');
+        }
+
+        // If both are null, just skip
+        if (localSdp == null && remoteSdp == null) {
+          return;
+        }
 
         final description = {
           'signalingState':
               StatParsingHelpers().parseSignalingStateChange(signalingState),
-          'remoteDescription': {
-            'type': remoteSdp?.type,
-            'sdp': remoteSdp?.sdp,
-          },
-          'localDescription': {
-            'type': localSdp?.type,
-            'sdp': localSdp?.sdp,
-          },
+          if (remoteSdp != null)
+            'remoteDescription': {
+              'type': remoteSdp.type,
+              'sdp': remoteSdp.sdp,
+            },
+          if (localSdp != null)
+            'localDescription': {
+              'type': localSdp.type,
+              'sdp': localSdp.sdp,
+            },
         };
 
         _sendDebugReportData(

diff --git a/packages/telnyx_webrtc/pubspec.yaml b/packages/telnyx_webrtc/pubspec.yaml
@@ -12,7 +12,7 @@ environment:
 dependencies:
   flutter:
     sdk: flutter
-  flutter_webrtc: ^0.12.7
+  flutter_webrtc: ^0.12.8
   logger: ^2.5.0
   uuid: ^4.5.1
   just_audio: ^0.9.43